From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XgC3k-0005Jk-Rj
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 08:27:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XgC3e-0003Ie-PF
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 08:27:36 -0400
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:21916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XgC3e-0003HA-Je
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 08:27:30 -0400
From: Don Slutz <dslutz@verizon.com>
Message-ID: <5444FFB0.6020601@terremark.com>
Date: Mon, 20 Oct 2014 08:27:28 -0400
MIME-Version: 1.0
References: <1413796790-30579-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1413796790-30579-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to
	--no-git-fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com

I am happy with this so:

Reviewed-by: Don Slutz <dslutz@verizon.com>

    -Don Slutz

On 10/20/14 05:19, Markus Armbruster wrote:
> Contributors rely on this script to find maintainers to copy.  The
> script falls back to git when no exact MAINTAINERS pattern matches.
> When that happens, recent contributors get copied, which tends not be
> particularly useful.  Some contributors find it even annoying.
>
> Flip the default to "don't fall back to git".  Use --git-fallback to
> ask it to fall back to git.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   scripts/get_maintainer.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 38334de..ec2d16f 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -28,7 +28,7 @@ my $email_git = 0;
>   my $email_git_all_signature_types = 0;
>   my $email_git_blame = 0;
>   my $email_git_blame_signatures = 1;
> -my $email_git_fallback = 1;
> +my $email_git_fallback = 0;
>   my $email_git_min_signatures = 1;
>   my $email_git_max_maintainers = 5;
>   my $email_git_min_percent = 5;