From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgFEv-00060O-CK for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:51:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgFEp-0000KR-76 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:51:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgFEp-0000KJ-0H for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:51:15 -0400 Message-ID: <54452F69.6080209@redhat.com> Date: Mon, 20 Oct 2014 17:51:05 +0200 From: Max Reitz MIME-Version: 1.0 References: <1413815720-29976-1-git-send-email-pl@kamp.de> <1413815720-29976-5-git-send-email-pl@kamp.de> In-Reply-To: <1413815720-29976-5-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] hw/virtio-blk: add a constant for max number of merged requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, benoit@irqsave.net, stefanha@redhat.com On 20.10.2014 at 16:35, Peter Lieven wrote: > As it was not obvious (at least for me) where the 32 comes from > add a constant for it. This needs some separator ("...comes from; add a..." or something like that). > Signed-off-by: Peter Lieven > --- > hw/block/virtio-blk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 6051027..23bc948 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -308,6 +308,8 @@ static bool virtio_blk_sect_range_ok(VirtIOBlock *dev, > return true; > } > > +#define MAX_MERGED_REQS 32 > + > static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb) > { > BlockRequest *blkreq; > @@ -326,7 +328,7 @@ static void virtio_blk_handle_write(VirtIOBlockReq *req, MultiReqBuffer *mrb) > block_acct_start(blk_get_stats(req->dev->blk), &req->acct, req->qiov.size, > BLOCK_ACCT_WRITE); > > - if (mrb->num_writes == 32) { > + if (mrb->num_writes == MAX_MERGED_REQS) { > virtio_submit_multiwrite(req->dev->blk, mrb); > } > I wouldn't have used the past form, but simply MAX_MERGE_REQS or, more complicated, MAX_MERGE_REQ_COUNT. But I'm me, and this mail's "From" field says it's not from me. Reviewed-by: Max Reitz