From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgG8g-0006DJ-MO for qemu-devel@nongnu.org; Mon, 20 Oct 2014 12:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgG8b-0005P9-Ni for qemu-devel@nongnu.org; Mon, 20 Oct 2014 12:48:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgG8b-0005P0-EG for qemu-devel@nongnu.org; Mon, 20 Oct 2014 12:48:53 -0400 Message-ID: <54453CED.40708@redhat.com> Date: Mon, 20 Oct 2014 10:48:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1413808195-7428-1-git-send-email-imammedo@redhat.com> <1413808195-7428-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1413808195-7428-3-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xW8gvIHCNisW1U0UICHcgKLK9fhvihiJ2" Subject: Re: [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xW8gvIHCNisW1U0UICHcgKLK9fhvihiJ2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/20/2014 06:29 AM, Igor Mammedov wrote: > use error_report_fatal() helper instead of a bunch of > if (local_err) { > error_report(foo); > error_free(local_err); > exit(1); > } > code blocks >=20 > Signed-off-by: Igor Mammedov > --- > * s/exit_if_error/error_report_fatal/ > * move error_report_fatal() into util/error.c > --- > include/qemu/error-report.h | 2 ++ > util/error.c | 24 ++++++++++++++++++++++++ > vl.c | 34 ++++++---------------------------- > 3 files changed, 32 insertions(+), 28 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xW8gvIHCNisW1U0UICHcgKLK9fhvihiJ2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJURTztAAoJEKeha0olJ0Nq4f0H/RccoSVm529RMjH5lGIZj3i0 VZE1Hsq1NporoL67PpjTDi0asW3RBDpgoBCfPx6zBgPO/evBJfKe+CGvxsC/jZLl J7GH1+EuO/w8+vMre5ELTGLtEc+FZVEEyv0V1Csmgc91hUg9VWtnzJBrZ3awfmtg sZpShnzkk10DEIbZoSlTAoD/7WkXiXHfDKqxOKzLhUftlgNFMrFvOJflIPdw/6rP 0JKAD9n1S9VuSk+pmWhCLaI7r92AIZnGwAWkjnAlHQRQENxO/bLw4PUsVDV+op/z dgR1kmYVhfTI2MB4DxDWdpSWh+xGCbERx1n25jP57Ic2m9vrk6T6gkc1rFe0NL0= =wasM -----END PGP SIGNATURE----- --xW8gvIHCNisW1U0UICHcgKLK9fhvihiJ2--