From: Jan Kiszka <jan.kiszka@web.de>
To: Knut Omang <knut.omang@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Le Tan <tamlokveer@gmail.com>,
Anthony Liguori <aliguori@amazon.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS
Date: Mon, 20 Oct 2014 20:18:23 +0200 [thread overview]
Message-ID: <544551EF.6050008@web.de> (raw)
In-Reply-To: <1413818157.7969.38.camel@ori.omang.mine.nu>
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
On 2014-10-20 17:15, Knut Omang wrote:
> On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote:
>> WRT intel_iommu, it does not yet seem to be as fully functional as I
>> hoped. People also discussed the best way to handle virtio versus iommu
>> (it bypasses it ATM).
>> I'd like to suggest we hide the iommu from the command line
>> help for 2.2, this way people don't activate it mistakenly.
>>
>> Let's make it more complete and then enable for 2.3.
>>
>> Thoughts?
>
> Note that you have to explicitly enable iommu support in the guest
> (intel_iommu=on on the boot command line in the Linux case) for it to
> have any effect apart from being visible in the DMAR table and logging
> so it should not really do any harm.
>
> From my perspective the feature works well and I have been running a few
> virtual machines with div.network workload stable using the additional 4
> patches referred to in this post (Jan's two for interrupt remapping and
> two bug fixes and enhancements from me for running behind bridges) :
>
> https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg02986.html
>
> Latest version here:
>
> https://github.com/knuto/qemu/tree/sriov_patches_v2
>
> Give me a hint and I can rebase and post the two iommu patches, I
> believe Jan wanted to do some more work on the interrupt remapping
> first.
You should avoid to depend on my series regarding upstreaming of fixes
or features that can be done independently. Did your bridging fixes
depend on IR? Can you break them up?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-10-20 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 9:40 [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS Michael S. Tsirkin
2014-10-20 11:41 ` Markus Armbruster
2014-10-20 12:14 ` Le Tan
2014-10-20 14:23 ` Michael S. Tsirkin
2014-10-20 14:37 ` Jan Kiszka
2014-10-20 17:20 ` Michael S. Tsirkin
2014-10-20 18:27 ` Jan Kiszka
2014-10-20 15:15 ` Knut Omang
2014-10-20 18:18 ` Jan Kiszka [this message]
2014-10-20 19:03 ` Knut Omang
2014-10-20 19:37 ` Knut Omang
2014-10-20 22:53 ` Knut Omang
2014-10-20 14:48 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544551EF.6050008@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=knut.omang@oracle.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).