From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgHn6-0000ic-Nr for qemu-devel@nongnu.org; Mon, 20 Oct 2014 14:34:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgHmx-0006t2-MX for qemu-devel@nongnu.org; Mon, 20 Oct 2014 14:34:48 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:53702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgHmu-0006rw-Ts for qemu-devel@nongnu.org; Mon, 20 Oct 2014 14:34:39 -0400 Received: by mail-wi0-f173.google.com with SMTP id fb4so7984299wid.12 for ; Mon, 20 Oct 2014 11:34:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <544555B6.8000600@redhat.com> Date: Mon, 20 Oct 2014 20:34:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1413446034-25167-1-git-send-email-dgilbert@redhat.com> <1413446034-25167-2-git-send-email-dgilbert@redhat.com> <8738aofnd6.fsf@elfo.elfo> <20141016081232.GF2590@work-vm> In-Reply-To: <20141016081232.GF2590@work-vm> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Juan Quintela Cc: qemu-devel@nongnu.org, ehabkost@redhat.com On 10/16/2014 10:12 AM, Dr. David Alan Gilbert wrote: > Yes; I suspect it's the vmstate_register_ram that uses TARGET_PAGE_MASK, > one of the patches in my postcopy world adds a function in exec.c that > returns TARGET_PAGE_BITS so that stuff that needs to know target page size > can make a call to find it out; that might solve that. Yeah, or you can just move vmstate_register_ram to migration/ram.c together with the arch_init.c bits. Paolo