Re: [PATCH 03/15] scripts/qmp: redirect qom-xxx scripts to python/qemu/qmp/

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 10/21/20 8:51 PM, John Snow wrote:
> Redirect to the new qom scripts. These forwarders can be deleted
> eventually when there has been more time for the dust on the Python
> packaging to settle and people understand how to find these commands.
> 
> Note: You can run these by setting $PYTHONPATH in your shell and then
> running "python3 -m qemu.qmp.qom", or you can install the qemu namespace
> package and use the "qom" or "qom-set" scripts.
> 
> I've written how to install the package elsewhere, but for the sake of
> git-blame, cd to ./python, and then do:
> 
> - pip3 install [--user] [-e] .
> 
> --user will install to your local user install (will not work inside of
>    a venv), omitting this flag installs to your system-wide packages
>    (outside of a venv) or to your current virtual environment (inside the
>    venv).
> 
>    When installing to a venv or to your system-wide packages, "qom"
>    should be in your $PATH already. If you do a user install, you may
>    need to add ~/.local/bin to your $PATH if you haven't already.
> 
> -e installs in editable mode: the installed package is effectively just
>   a symlink to this folder; so changes to your git working tree are
>   reflected in the installed package.
> 
> Alternatively to the above, If you have `pipenv` installed (`pip3
> install --user pipenv`), you may also invoke 'pipenv shell' to enter a
> pipenv-managed virtual environment (as a shell process that you may
> leave with ctrt+d) that has 'qom' already in $PATH.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   scripts/qmp/qom-get  | 66 +++------------------------------------
>   scripts/qmp/qom-list | 63 +++----------------------------------
>   scripts/qmp/qom-set  | 63 +++----------------------------------
>   scripts/qmp/qom-tree | 74 +++-----------------------------------------
>   4 files changed, 16 insertions(+), 250 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>