From: Peter Lieven <pl@kamp.de>
To: Max Reitz <mreitz@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2
Date: Tue, 21 Oct 2014 09:43:08 +0200 [thread overview]
Message-ID: <54460E8C.3090904@kamp.de> (raw)
In-Reply-To: <544605EA.7060900@redhat.com>
On 21.10.2014 09:06, Max Reitz wrote:
> On 2014-10-20 at 22:48, Peter Lieven wrote:
>> Am 20.10.2014 um 17:56 schrieb Max Reitz <mreitz@redhat.com>:
>>
>>> On 20.10.2014 at 16:35, Peter Lieven wrote:
>>>> This adds some preparing patches for upcoming multiwrite modifications.
>>>> I will leave the dangerous patches for after 2.2 release.
>>>>
>>>> Peter Lieven (4):
>>>> block: add accounting for merged requests
>>>> block: introduce bdrv_runtime_opts
>>>> block: add a knob to disable multiwrite_merge
>>>> hw/virtio-blk: add a constant for max number of merged requests
>>> In addition, I'd like a test for this (just the parameter would be enough). But I don't object to this series without it.
>> Thanks for your comments. I will respin tomorrow.
>>
>> What exactly would you like to check in a test?
>
> Just give the parameter and test the query-block against it. I'd test the default, switching it on, off and maybe even specify it for a non-root BDS to see whether that works.
Understood.
Thanks
Peter
next prev parent reply other threads:[~2014-10-21 7:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 14:35 [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2 Peter Lieven
2014-10-20 14:35 ` [Qemu-devel] [PATCH 1/4] block: add accounting for merged requests Peter Lieven
2014-10-20 15:08 ` Max Reitz
2014-10-20 14:35 ` [Qemu-devel] [PATCH 2/4] block: introduce bdrv_runtime_opts Peter Lieven
2014-10-20 15:27 ` Max Reitz
2014-10-20 14:35 ` [Qemu-devel] [PATCH 3/4] block: add a knob to disable multiwrite_merge Peter Lieven
2014-10-20 15:41 ` Max Reitz
2014-10-20 14:35 ` [Qemu-devel] [PATCH 4/4] hw/virtio-blk: add a constant for max number of merged requests Peter Lieven
2014-10-20 15:51 ` Max Reitz
2014-10-20 15:56 ` [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2 Max Reitz
2014-10-20 20:48 ` Peter Lieven
2014-10-21 7:06 ` Max Reitz
2014-10-21 7:43 ` Peter Lieven [this message]
2014-10-21 8:01 ` Peter Lieven
2014-10-21 9:07 ` Max Reitz
2014-10-21 9:38 ` Kevin Wolf
2014-10-21 9:54 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54460E8C.3090904@kamp.de \
--to=pl@kamp.de \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).