Re: [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2

[Max Reitz <mreitz@redhat.com>]

On 2014-10-21 at 11:38, Kevin Wolf wrote:
> Am 21.10.2014 um 11:07 hat Max Reitz geschrieben:
>> On 2014-10-21 at 10:01, Peter Lieven wrote:
>>> On 21.10.2014 09:06, Max Reitz wrote:
>>>> On 2014-10-20 at 22:48, Peter Lieven wrote:
>>>>> Am 20.10.2014 um 17:56 schrieb Max Reitz <mreitz@redhat.com>:
>>>>>
>>>>>> On 20.10.2014 at 16:35, Peter Lieven wrote:
>>>>>>> This adds some preparing patches for upcoming multiwrite
>>>>>>> modifications.
>>>>>>> I will leave the dangerous patches for after 2.2 release.
>>>>>>>
>>>>>>> Peter Lieven (4):
>>>>>>>    block: add accounting for merged requests
>>>>>>>    block: introduce bdrv_runtime_opts
>>>>>>>    block: add a knob to disable multiwrite_merge
>>>>>>>    hw/virtio-blk: add a constant for max number of merged requests
>>>>>> In addition, I'd like a test for this (just the parameter
>>>>>> would be enough). But I don't object to this series without
>>>>>> it.
>>>>> Thanks for your comments. I will respin tomorrow.
>>>>>
>>>>> What exactly would you like to check in a test?
>>>> Just give the parameter and test the query-block against it. I'd
>>>> test the default, switching it on, off and maybe even specify it
>>>> for a non-root BDS to see whether that works.
>>> It seems it is currently not visible in query-block which
>>> paramters are set to e.g. file. If I specifiy -drive
>>> file.write_merging=off its accepted but not displayed. Any ideas?
>> Hm, I forgot that query-block only gives you the root BDS. Too bad.
>> Then we cannot test that. We probably want to have a QMP command to
>> query the whole BDS graph some time, but it isn't there yet.
> Does query-named-block-nodes help in this specific case?

Oh, yes, it does. :-)

I think I should learn QMP once in a while...

Max