From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgb5x-0005S9-LU for qemu-devel@nongnu.org; Tue, 21 Oct 2014 11:11:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xgb5r-0004zu-Hd for qemu-devel@nongnu.org; Tue, 21 Oct 2014 11:11:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgb5r-0004zq-AE for qemu-devel@nongnu.org; Tue, 21 Oct 2014 11:11:27 -0400 Message-ID: <5446779D.90607@redhat.com> Date: Tue, 21 Oct 2014 10:11:25 -0500 From: Wei Huang MIME-Version: 1.0 References: <1412711059-12524-1-git-send-email-wei@redhat.com> <543453D9.8020706@redhat.com> <54345843.8070703@redhat.com> <54345CC8.8050806@redhat.com> <54348850.9080808@redhat.com> <5434EC14.5060806@redhat.com> <5436EE6A.6030705@redhat.com> <5436F933.8080204@redhat.com> <20141009221644.GP4178@thinpad.lan.raisama.net> In-Reply-To: <20141009221644.GP4178@thinpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] target-i386: prevent users from setting threads>1 for AMD CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Paolo Bonzini Cc: afaerber@suse.de, qemu-devel@nongnu.org Patch posted. I will post another one for virt-manager. -Wei On 10/09/2014 05:16 PM, Eduardo Habkost wrote: > On Thu, Oct 09, 2014 at 11:08:03PM +0200, Paolo Bonzini wrote: >> Il 09/10/2014 22:22, Wei Huang ha scritto: >>> >>> Given that back-ward compatibility is a concern, will the following work? >>> >>> 1. Instead of bailing out, print a warning message (e.g. to log file via >>> error_report) in QEMU. >>> 2. [optional] Eduardo Habkost suggested that we can create a new machine >>> model which more strictly checks threads=n option for AMD. For any >>> existing machine config, we don't force it; but warning message still >>> applies. This is optional because it is a bit over-killed IMO. >>> 3. Gives out a warning in virt-manager as well. This is similar to >>> "Overcomming CPUs will slow down performance" in current virt-manager >>> screen. The message will read "Chosen CPU model doesn't support >>> hyperthreading" or something similar. >> >> I like (1) and (3). > > I don't think we really need (2), either. The current problem is just > user confusion, so properly warning the user is the best thing to do. >