From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xgtil-00072r-R2
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 07:04:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xgtih-0007yE-Fg
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 07:04:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xgtih-0007x6-8U
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 07:04:47 -0400
Message-ID: <54478F47.8030300@redhat.com>
Date: Wed, 22 Oct 2014 13:04:39 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1413900183-28617-1-git-send-email-roger.pau@citrix.com>
In-Reply-To: <1413900183-28617-1-git-send-email-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] block: char devices on FreeBSD are not
 behind a pager
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roger Pau Monne <roger.pau@citrix.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-10-21 at 16:03, Roger Pau Monne wrote:
> Introduce a new flag to mark devices that require requests to be aligne=
d and
> replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when
> appropriate.
>
> If a character device is used as a backend on a FreeBSD host set this f=
lag
> unconditionally.
>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Changes since v2:
>   - s/alignement/alignment/.
>   - Don't make needs_alignment a bit field.
>   - Add braces to single statement conditional block.
>
> Changes since v1:
>   - Intead of appending BDRV_O_NOCACHE and O_DIRECT when a char dev is =
used
>     on FreeBSD introduce a new flag that is used to mark if a device ne=
eds
>     requests to be aligned.
> ---
>   block/raw-posix.c | 26 +++++++++++++++++++++-----
>   1 file changed, 21 insertions(+), 5 deletions(-)

Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block

Max