From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1 if no maintainer found
Date: Wed, 22 Oct 2014 14:32:15 +0200 [thread overview]
Message-ID: <5447A3CF.5020304@redhat.com> (raw)
In-Reply-To: <87iojccnlc.fsf@blackfin.pond.sub.org>
> Thus, the patch makes the script exit with status 1 when none of the
> above output() calls produces output.
>
> Maybe it exits with status 1 when it fails to produce output? Obvious
> ouput elsewhere: printing the version (okay),
That exits with 0.
> and a print in get_maintainers(). Can't tell what the latter does. Hmm.
That is for --sections, and you're right, this is missing:
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index f4fee27..e682d1f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -617,6 +617,7 @@ sub get_maintainers {
print("$line\n");
}
print("\n");
+ $exit = 0;
}
}
}
Paolo
next prev parent reply other threads:[~2014-10-22 12:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 9:08 [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl Paolo Bonzini
2014-10-22 9:08 ` [Qemu-devel] [PATCH 1/4] get_maintainer.pl: exit with status 1 if no maintainer found Paolo Bonzini
2014-10-22 12:09 ` Markus Armbruster
2014-10-22 12:32 ` Paolo Bonzini [this message]
2014-10-22 9:08 ` [Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same Paolo Bonzini
2014-10-22 9:24 ` Michael S. Tsirkin
2014-10-22 9:08 ` [Qemu-devel] [PATCH 3/4] get_maintainer.pl: move git loop under "if ($email) {" Paolo Bonzini
2014-10-22 9:08 ` [Qemu-devel] [PATCH 4/4] get_maintainer.pl: point at --git-fallback instead of enabling it automatically Paolo Bonzini
2014-10-22 9:33 ` Michael S. Tsirkin
2014-10-22 9:56 ` Paolo Bonzini
2014-10-22 10:13 ` Thomas Huth
2014-10-22 10:17 ` Michael S. Tsirkin
2014-10-22 10:30 ` Paolo Bonzini
2014-10-22 12:55 ` Markus Armbruster
2014-10-22 10:17 ` [Qemu-devel] [PATCH 0/4] small improvements to get_maintainer.pl Thomas Huth
2014-10-22 10:28 ` Michael S. Tsirkin
2014-10-22 10:42 ` Paolo Bonzini
2014-10-22 12:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447A3CF.5020304@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).