From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for map commands
Date: Wed, 22 Oct 2014 15:54:38 +0200 [thread overview]
Message-ID: <5447B71E.1080701@redhat.com> (raw)
In-Reply-To: <20141022135112.GO3188@noname.str.redhat.com>
On 2014-10-22 at 15:51, Kevin Wolf wrote:
> Am 22.10.2014 um 15:24 hat Max Reitz geschrieben:
>> Add a test for qemu-img map and qemu-io -c map on truncated files.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> But how about adding a case for patch 2, too? Or is that one mostly
> theoretical (like the image file being modified in the background) and
> not reproducible reliably?
See the cover letter, I could not find a way to test patch 2 without
triggering the changes introduced by patch 1. Yes, modifying the image
in the background could be a way to do this. I could try, but I don't
know if we really need a test for it.
I'll give myself a couple of minutes and if it doesn't work, well, then
this test stays the same in v3.
Max
next prev parent reply other threads:[~2014-10-22 13:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 13:24 [Qemu-devel] [PATCH v2 0/3] block: Fix is_allocated() for truncated images Max Reitz
2014-10-22 13:24 ` [Qemu-devel] [PATCH v2 1/3] block: Respect underlying file's EOF Max Reitz
2014-10-22 13:40 ` Kevin Wolf
2014-10-22 13:42 ` Max Reitz
2014-10-22 13:24 ` [Qemu-devel] [PATCH v2 2/3] qemu-io: Respect early image end for map Max Reitz
2014-10-22 13:45 ` Kevin Wolf
2014-10-22 13:24 ` [Qemu-devel] [PATCH v2 3/3] iotests: Add test for map commands Max Reitz
2014-10-22 13:51 ` Kevin Wolf
2014-10-22 13:54 ` Max Reitz [this message]
2014-10-22 14:48 ` Max Reitz
2014-10-22 14:48 ` Max Reitz
2014-10-22 13:27 ` [Qemu-devel] [PATCH v2 0/3] block: Fix is_allocated() for truncated images Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447B71E.1080701@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).