From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43148)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xh2SH-0001FX-1j
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 16:24:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Xh2SA-0004GJ-36
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 16:24:24 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:46248 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xh2S9-0004GB-OM
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 16:24:18 -0400
Message-ID: <5448126D.8030106@kamp.de>
Date: Wed, 22 Oct 2014 22:24:13 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1413984120-21830-1-git-send-email-pl@kamp.de>
	<1413984120-21830-4-git-send-email-pl@kamp.de>
	<5447F798.1060609@redhat.com>
In-Reply-To: <5447F798.1060609@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 3/6] block: add a knob to disable
	multiwrite_merge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com

Am 22.10.2014 um 20:29 schrieb Eric Blake:
> On 10/22/2014 07:21 AM, Peter Lieven wrote:
>> The block layer silently merges write requests since
>> commit 40b4f539. This patch adds a knob to disable
>> this feature as there has been some discussion lately
>> if multiwrite is a good idea at all and as it falsifies
>> benchmarks.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
> Is the double s-o-b intentional?

Mistake

>
>
>> +++ b/hmp.c
>> @@ -348,6 +348,10 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)
>>                             BlockdevDetectZeroesOptions_lookup[info->value->inserted->detect_zeroes]);
>>          }
>>  
>> +        if (!info->value->inserted->write_merging) {
>> +            monitor_printf(mon, "    Write Merging:    off\n");
>> +        }
> Is it also worth printing something if write merging is enabled?
>

Enabled Write Merging is the default since 2009. We do not display
all other defaults as well. But I don't mind.

Peter