From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDPd-00047O-El
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:06:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDPY-0004kE-HI
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:06:25 -0400
Received: from szxga01-in.huawei.com ([119.145.14.64]:49981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XhDPX-0004ja-TJ
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 04:06:20 -0400
Message-ID: <5448B6DA.5010702@huawei.com>
Date: Thu, 23 Oct 2014 16:05:46 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1414046016-10360-1-git-send-email-arei.gonglei@huawei.com>
	<1414051026.30724.4.camel@nilsson.home.kraxel.org>
In-Reply-To: <1414051026.30724.4.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>

On 2014/10/23 15:57, Gerd Hoffmann wrote:

> On Do, 2014-10-23 at 14:33 +0800, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> When using qmp change vnc interface, will leak fd
>> of vs->lsock and vs->lwebsock (if configed). Close
>> them before: re-evaluate.
> 
> Ah, the file handles are leaked because you dropped the
> vnc_display_close() call.  Don't do that then ...
> 
Oops, understand. Sorry for the noise :(


What's your suggestion about the problem described in cover-letter? Gerd


Best regards,
-Gonglei