From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhGPh-0000kQ-Q9 for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:18:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhGPc-0003xt-Sf for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:18:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhGPc-0003xl-JG for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:18:36 -0400 Message-ID: <5448E403.30602@redhat.com> Date: Thu, 23 Oct 2014 13:18:27 +0200 From: Max Reitz MIME-Version: 1.0 References: <1413446090-30050-1-git-send-email-pl@kamp.de> <1413446090-30050-4-git-send-email-pl@kamp.de> In-Reply-To: <1413446090-30050-4-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv4 3/4] block/iscsi: set max_transfer_length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com On 2014-10-16 at 09:54, Peter Lieven wrote: > the limit of 0xffffff for 16 byte CDBs is intentional to > avoid overflows on 32-bit architectures. How is it related to 32 bit? I somehow feel like it has to do something with the result of sector_lun2qemu() which involves block_size... > Signed-off-by: Peter Lieven > Reviewed-by: Ronnie Sahlberg > --- > block/iscsi.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 3a01de0..c873d13 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1449,10 +1449,18 @@ static void iscsi_close(BlockDriverState *bs) > > static void iscsi_refresh_limits(BlockDriverState *bs, Error **errp) > { > - IscsiLun *iscsilun = bs->opaque; > - > /* We don't actually refresh here, but just return data queried in > * iscsi_open(): iscsi targets don't change their limits. */ > + > + IscsiLun *iscsilun = bs->opaque; > + uint32_t max_xfer_len = iscsilun->use_16_for_rw ? 0xffffff : 0xffff; > + > + if (iscsilun->bl.max_xfer_len) { > + max_xfer_len = MIN(max_xfer_len, iscsilun->bl.max_xfer_len); > + } > + > + bs->bl.max_transfer_length = sector_lun2qemu(max_xfer_len, iscsilun); > + > if (iscsilun->lbp.lbpu) { > if (iscsilun->bl.max_unmap < 0xffffffff) { > bs->bl.max_discard = sector_lun2qemu(iscsilun->bl.max_unmap,