From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51273)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XhGmZ-0007zP-LZ
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:42:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XhGmT-0004UP-8l
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:42:19 -0400
Received: from mail-wi0-f171.google.com ([209.85.212.171]:55334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XhGmT-0004SC-2e
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 07:42:13 -0400
Received: by mail-wi0-f171.google.com with SMTP id em10so3864325wid.16
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2014 04:42:11 -0700 (PDT)
Message-ID: <5448E95C.4080706@linaro.org>
Date: Thu, 23 Oct 2014 13:41:16 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <5448D400.6010503@linaro.org>
	<CAKv+Gu8q3eJK_9iCMP42rVY2-rqjp4t-SSZfDZNyZpM+LWPFWg@mail.gmail.com>
	<5448E515.80300@suse.de>
	<CAFEAcA-tnSgRig_qE2abAAP6gmoGJoZFaxHwu1m3059GLEKD4w@mail.gmail.com>
	<5448E5D0.6070701@suse.de>
In-Reply-To: <5448E5D0.6070701@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] dynamic sysbus instantiation and load_dtb
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>, qemu list <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Antonios Motakis <a.motakis@virtualopensystems.com>, Christoffer Dall <christoffer.dall@linaro.org>

Hi,

Thanks everyone for entering the thread & reading my long email.

Alex, I indeed can register the notifier in the machine file after the
platform bus instantiation. This indeed guarantees the notifiers are
called in the right order ...

Thanks

Best Regards

Eric

On 10/23/2014 01:26 PM, Alexander Graf wrote:
> 
> 
> On 23.10.14 13:24, Peter Maydell wrote:
>> On 23 October 2014 12:23, Alexander Graf <agraf@suse.de> wrote:
>>> On 23.10.14 12:19, Ard Biesheuvel wrote:
>>>> The reason for this change was that, before, the DTB would only be
>>>> generated once, and after a reset, the machine would go through the
>>>> kernel boot protocol as before but the DTB pointer would point to
>>>> garbage. Any idea how ppc deals with this? Do they recreate the device
>>>> tree after each reset?
>>>
>>> Yes, we regenerate the device tree on each reset.
>>
>> Any particular reason? Surely it's always the same...
> 
> We have the code in place anyway, it's not a performance critical code
> path and putting it into a rom would be a waste of RAM, as it'd keep yet
> another copy of something we can easily regenerate.
> 
> It's a matter of personal preference I guess.
> 
> 
> Alex
>