From: Richard Henderson <rth@twiddle.net>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: mark.burton@greensocs.com, batuzovk@ispras.ru,
maria.klimushenkova@ispras.ru, pbonzini@redhat.com,
zealot351@gmail.com, fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [PATCH] i386: fix icount processing for repz instructions
Date: Thu, 23 Oct 2014 10:05:27 -0700 [thread overview]
Message-ID: <54493557.2040106@twiddle.net> (raw)
In-Reply-To: <20141021130351.3780.41554.stgit@PASHA-ISP>
On 10/21/2014 06:03 AM, Pavel Dovgalyuk wrote:
> + dc->repz_opt = dc->jmp_opt
> + /* Do not optimize repz jumps at all in icount mode, because
> + rep movsS instructions are execured with different paths
> + in repz_opt and !repz_opt modes. The first one was used
> + always except single step mode. And this setting
> + disables jumps optimization and control paths become
> + equivalent in run and single step modes.
> + Now there will be no jump optimization for repz in
> + trace and replay modes and there will always be an
> + additional step for ecx=0.
> + */
> + || use_icount;
My aesthetics are offended by the placement of this comment. Please write
/* Comment */
dc->repz_opt = x || y;
That said, surely that test should be !use_icount.
r~
next prev parent reply other threads:[~2014-10-23 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 13:03 [Qemu-devel] [PATCH] i386: fix icount processing for repz instructions Pavel Dovgalyuk
2014-10-23 17:05 ` Richard Henderson [this message]
2014-10-23 20:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54493557.2040106@twiddle.net \
--to=rth@twiddle.net \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=batuzovk@ispras.ru \
--cc=fred.konrad@greensocs.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).