From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XhMF6-0002EN-Br
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 13:32:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XhMF0-0001Sm-UI
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 13:32:08 -0400
Received: from mail-yh0-x234.google.com ([2607:f8b0:4002:c01::234]:36240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XhMF0-0001SN-Pw
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 13:32:02 -0400
Received: by mail-yh0-f52.google.com with SMTP id f10so1618353yha.25
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2014 10:32:02 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54493B8E.7020901@twiddle.net>
Date: Thu, 23 Oct 2014 10:31:58 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1414065329-7357-1-git-send-email-riku.voipio@linaro.org>
	<CAFEAcA8uDvuORyJ-NdR_SYRkF9PX4D4o=4-S_8fZmdCbkb9pSA@mail.gmail.com>
In-Reply-To: <CAFEAcA8uDvuORyJ-NdR_SYRkF9PX4D4o=4-S_8fZmdCbkb9pSA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation
 AArch64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@linaro.org>
Cc: Amanieu <amanieu@gmail.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>

On 10/23/2014 05:06 AM, Peter Maydell wrote:
> On 23 October 2014 12:55,  <riku.voipio@linaro.org> wrote:
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
>> because the fault address passes through an uint32_t variable. This
>> is fixed by changing the variable to uint64_t.
>>
>> v2 by Riku - follow Peters suggestion and drop the addr variable
>> since its only used once in the Aarch64 loop.
>>
>> Reported-by: Amanieu d'Antras <amanieu@gmail.com>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> 
> Ah, I was just wondering this morning whether I ought
> to do a version of this patch, so you've saved me the effort :-)
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> (You might want to put the notes about v2 below the '---'.)

If you do that, please just modify the entire patch description.
I.e. don't talk about the type of a variable that doesn't exist.


r~