From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: Add test for external image truncation
Date: Fri, 24 Oct 2014 08:11:54 -0600 [thread overview]
Message-ID: <544A5E2A.90102@redhat.com> (raw)
In-Reply-To: <1414148280-17949-4-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On 10/24/2014 04:58 AM, Max Reitz wrote:
> It should not be happening, but it is possible to truncate an image
> outside of qemu while qemu is running (or any of the qemu tools using
> the block layer. raw_co_get_block_status() should not break then.
>
> While touching this test, replace the existing "truncate" invocation by
> "$QEMU_IMG convert -f raw".
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/102 | 21 +++++++++++++++++++--
> tests/qemu-iotests/102.out | 11 +++++++++++
> 2 files changed, 30 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-24 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 10:57 [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-10-24 10:57 ` [Qemu-devel] [PATCH v4 1/3] raw-posix: Fix raw_co_get_block_status() after EOF Max Reitz
2014-10-24 10:57 ` [Qemu-devel] [PATCH v4 2/3] raw-posix: raw_co_get_block_status() return value Max Reitz
2014-10-24 10:58 ` [Qemu-devel] [PATCH v4 3/3] iotests: Add test for external image truncation Max Reitz
2014-10-24 14:11 ` Eric Blake [this message]
2014-10-28 14:27 ` [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status() Kevin Wolf
2014-10-29 10:01 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A5E2A.90102@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).