From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhgZO-0006Yj-AZ for qemu-devel@nongnu.org; Fri, 24 Oct 2014 11:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhgZJ-0007yP-KV for qemu-devel@nongnu.org; Fri, 24 Oct 2014 11:14:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhgZJ-0007xq-Bn for qemu-devel@nongnu.org; Fri, 24 Oct 2014 11:14:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9OFEJrf027076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Oct 2014 11:14:20 -0400 Message-ID: <544A6CCA.6030002@redhat.com> Date: Fri, 24 Oct 2014 09:14:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414159063-25977-1-git-send-email-mreitz@redhat.com> <1414159063-25977-7-git-send-email-mreitz@redhat.com> In-Reply-To: <1414159063-25977-7-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rHjd4mMWvvrASOP0ORne2qaVopLOM5XBr" Subject: Re: [Qemu-devel] [PATCH v14 06/14] iotests: Omit length/offset test in 040 and 041 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rHjd4mMWvvrASOP0ORne2qaVopLOM5XBr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/24/2014 07:57 AM, Max Reitz wrote: > As of a follow-up patch to this one, the length of a mirror block job > will no longer directly depend on the size of the block device; > therefore, drop these checks from this test. Instead, just check whethe= r > the final offset equals the block job length. >=20 > As 041 uses the wait_until_completed function from iotests.py, the same= > applies there as well which in turn affects tests 030, 055 and 056. On > the other hand, a block job's length does not have to be related to the= > length of the image file in the first place, so that check was > questionable anyway. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/040 | 4 +--- > tests/qemu-iotests/041 | 5 +---- > tests/qemu-iotests/iotests.py | 3 +-- > 3 files changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rHjd4mMWvvrASOP0ORne2qaVopLOM5XBr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUSmzKAAoJEKeha0olJ0Nqn/IIAJPcMGT+NKSiHdGn1TwUYT3C irNn8i5Am3yXju/UOzeq7nRq/RcLMfqsNomB/WJG30byTi3D9MXDkdg89y2vMYkw o8O1/lsreWgm5KtUNfq5SYeFgf8YiQ0tsjLId07l7n8k+w10iUVhbzIdJdT6oQ/S Z4QwB6T6W+K7w3dwxNdaNYamLQMdkO99i+UWTHeuyaaj36/qrFj+rOH6d7N+WqvU j4zv8eqCCEDhmDKV70DtF/i2AHoVymvkcIaMnN3pMiJLy3IcTQFwKZUpMFPbAl1C nH9loMrfwaFm2TR9QjbSwKrmRiPcUAW5CWU7a6LuKirkbuci2E8KwN1RxgKIQaY= =PXLa -----END PGP SIGNATURE----- --rHjd4mMWvvrASOP0ORne2qaVopLOM5XBr--