From: Leon Alrae <leon.alrae@imgtec.com>
To: Richard Henderson <rth@twiddle.net>,
Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>,
qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, zealot351@gmail.com,
maria.klimushenkova@ispras.ru, alex.bennee@linaro.org,
batuzovk@ispras.ru
Subject: Re: [Qemu-devel] [PATCH] arm: fix TB alignment check
Date: Fri, 24 Oct 2014 17:08:09 +0100 [thread overview]
Message-ID: <544A7969.90200@imgtec.com> (raw)
In-Reply-To: <5449299B.9070902@twiddle.net>
On 23/10/2014 17:15, Richard Henderson wrote:
> [3] Hello, MIPS. Leon, the test for mips is (now) incorrect:
>
> if ((ctx.pc & (TARGET_PAGE_SIZE - 1)) == 0)
> break;
>
> may never succeed for mips16 and micromips.
Indeed, this test doesn't look right (although I'm not sure what exactly
are the consequences if the test doesn't succeed and we span two or more
pages). Thanks for spotting this in MIPS.
Regards,
Leon
next prev parent reply other threads:[~2014-10-24 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:14 [Qemu-devel] [PATCH] arm: fix TB alignment check Pavel Dovgalyuk
2014-10-23 13:18 ` Peter Maydell
2014-10-23 13:42 ` Laurent Desnogues
2014-10-23 16:15 ` Richard Henderson
2014-10-23 16:25 ` Peter Maydell
2014-10-23 16:33 ` Richard Henderson
2014-10-24 5:24 ` Pavel Dovgaluk
2014-10-24 16:08 ` Leon Alrae [this message]
2015-09-19 10:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A7969.90200@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=maria.klimushenkova@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).