From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhhQA-0006Bj-Bx for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:09:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhhQ5-0001OP-EW for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:08:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhhQ5-0001OG-6F for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:08:53 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9OG8qDP017549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Oct 2014 12:08:52 -0400 Message-ID: <544A7993.1090806@redhat.com> Date: Fri, 24 Oct 2014 10:08:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414159063-25977-1-git-send-email-mreitz@redhat.com> <1414159063-25977-9-git-send-email-mreitz@redhat.com> In-Reply-To: <1414159063-25977-9-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XA9XEM7DaTw9RO4foIqOuqidNd6vlRhjh" Subject: Re: [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XA9XEM7DaTw9RO4foIqOuqidNd6vlRhjh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/24/2014 07:57 AM, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically requir= e > just everything being linked into qemu-img), imitate QMP's > implementation of block-commit by using commit_active_start() and then > waiting for the block job to finish. >=20 > Signed-off-by: Max Reitz > --- > block/Makefile.objs | 3 +-- > qemu-img.c | 78 ++++++++++++++++++++++++++++++++++++++++-----= -------- > 2 files changed, 60 insertions(+), 21 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XA9XEM7DaTw9RO4foIqOuqidNd6vlRhjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUSnmTAAoJEKeha0olJ0NqSxgIAIE8Ae3yHmz2F2AO/j6oECqH +4T/9QMATHWtJ3tIIpUL4iZFxDlVsgGKQnOjtu062z1GieCJq9fNiJAIH9Gv8tTK 5+Rdw8bquobzyhl/xtrWGAO4+hnacN4DrH++g2Px+2bEI/03NJAG1jlhXYtqT5Ty pjRbi6V15gAiK/wZkv1emXklx9+JvLDKsMn5zF5TpcUH6Cgmu8l74hX4Z9S+JA4K Aqq4FKdJ2HHAJPIodSQb5vSt0CP1WWgn652CNFSkBel69Ura4GFE8i2C3GVNqlFX dg7UeQYCingA9e8eIVE3A+K/uJ4xjrhqbt6kDjQ6fbVRr3WrrwFwWQj9W+Bak1E= =DpHW -----END PGP SIGNATURE----- --XA9XEM7DaTw9RO4foIqOuqidNd6vlRhjh--