From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhhmB-0005Ck-G8 for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:31:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xhhm6-0000Y3-Fc for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:31:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xhhm6-0000Xm-6U for qemu-devel@nongnu.org; Fri, 24 Oct 2014 12:31:38 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9OGVbww006247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Oct 2014 12:31:37 -0400 Message-ID: <544A7EE8.6070008@redhat.com> Date: Fri, 24 Oct 2014 10:31:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414159063-25977-1-git-send-email-mreitz@redhat.com> <1414159063-25977-15-git-send-email-mreitz@redhat.com> In-Reply-To: <1414159063-25977-15-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7EPAuP8MLqHr3WDEmV8axOcFuwlJ2Q2Im" Subject: Re: [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7EPAuP8MLqHr3WDEmV8axOcFuwlJ2Q2Im Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/24/2014 07:57 AM, Max Reitz wrote: > Add a test for qcow2's fast bdrv_make_empty implementation on images > without internal snapshots. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/098 | 82 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/098.out | 52 +++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 135 insertions(+) > create mode 100755 tests/qemu-iotests/098 > create mode 100644 tests/qemu-iotests/098.out >=20 > + > +IMGOPTS=3D"compat=3D1.1" > + > +for event in l1_update empty_image_prepare reftable_update refblock_al= loc; do Is it also worth a test where no I/O error occurs, to be sure we cover the common case output? Maybe by adding '' to this list... > + > +echo > +echo "=3D=3D=3D $event =3D=3D=3D" > +echo > + > +TEST_IMG=3D"$TEST_IMG.base" _make_test_img 64M > +_make_test_img -b "$TEST_IMG.base" 64M > + > +# Some data that can be leaked when emptying the top image > +$QEMU_IO -c 'write 0 64k' "$TEST_IMG" | _filter_qemu_io > + > +cat > "$TEST_DIR/blkdebug.conf" < +[inject-error] > +event =3D "$event" > +EOF =2E..and changing this file to be a no-op if $event is empty? But as written, the test is nice. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7EPAuP8MLqHr3WDEmV8axOcFuwlJ2Q2Im Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUSn7oAAoJEKeha0olJ0NqIdwIAKBjUw9NX4SthngunixI+l+W PEySzyQkBl12wLbibNNGWsy0WjrZo/k66z/T44suJ6O/djqb6h0glTc3xZXrB6++ Kjz/NANW7H/1hOy03p+vkUOHruwbafaLmD2PKGb7FLCktK+owuGz5cGc4Xj+6iwn 84i4Z+vcewBQbF6idoz9JP5VKutevJTgb1zR5LVhCwYtSotsm8q17CfwPAKrCEHk VFUi1+KxRnOXiuBWh6JFB//RLEnytO3Lrfbr7H5zMpc0M/lC0MqeXyfJE/9nyVIH YeVyYnrv5sE9Kfjqjr5Gy5sWe4rb92QCSLCePSg14j/ua8qmQlKaheq03cFN7fs= =9hWD -----END PGP SIGNATURE----- --7EPAuP8MLqHr3WDEmV8axOcFuwlJ2Q2Im--