From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xi2nb-00014D-AA for qemu-devel@nongnu.org; Sat, 25 Oct 2014 10:58:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xi2nV-0007qu-KK for qemu-devel@nongnu.org; Sat, 25 Oct 2014 10:58:35 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:53869 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xi2nV-0007qj-A4 for qemu-devel@nongnu.org; Sat, 25 Oct 2014 10:58:29 -0400 Message-ID: <544BBA8F.5010908@kamp.de> Date: Sat, 25 Oct 2014 16:58:23 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1413805631-11626-1-git-send-email-pl@kamp.de> <20141022120323.GG3188@noname.str.redhat.com> In-Reply-To: <20141022120323.GG3188@noname.str.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: qemu-iotests change _supported_proto to file once more. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, benoit@irqsave.net, hutao@cn.fujitsu.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, lersek@redhat.com Am 22.10.2014 um 14:03 schrieb Kevin Wolf: > Am 20.10.2014 um 13:47 hat Peter Lieven geschrieben: >> In preparation to possible automatic regression and performance >> testing for the block layer I found that the iotests don't work >> for all protocols anymore. >> >> In commit 1f7bf7d0 I started to change supported protocols from >> generic to file for various tests. Unfortunately, some tests >> added in the meantime again carry generic protocol altough they >> can only work with file because they require local file access. >> >> The other way around for some tests that only support file I added >> NFS protocol after confirming they work. >> >> Signed-off-by: Peter Lieven > Thanks, applied to the block branch. > > I suspect the test cases where you added nfs are actually generic. Did > you check this? Thinking about this again. Generic is probably wrong because not all protocols support bdrv_create. Peter