From: Gonglei <arei.gonglei@huawei.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
Gonglei <arei.gonglei@hotmail.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"
Date: Sun, 26 Oct 2014 17:42:19 +0800 [thread overview]
Message-ID: <544CC1FB.7060702@huawei.com> (raw)
In-Reply-To: <544CBFB0.7010701@web.de>
On 2014/10/26 17:32, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks
> debuggability of qemu.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
Thanks, please add my 'Reported-by' tag and
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
> Feel free to apply this before or after "Make qemu_shutdown_requested
> signal-safe".
>
> main-loop.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/main-loop.c b/main-loop.c
> index d2e64f1..53393a4 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -84,9 +84,6 @@ static int qemu_signal_init(void)
> sigaddset(&set, SIGIO);
> sigaddset(&set, SIGALRM);
> sigaddset(&set, SIGBUS);
> - sigaddset(&set, SIGINT);
> - sigaddset(&set, SIGHUP);
> - sigaddset(&set, SIGTERM);
> pthread_sigmask(SIG_BLOCK, &set, NULL);
>
> sigdelset(&set, SIG_IPI);
next prev parent reply other threads:[~2014-10-26 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 9:32 [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously" Jan Kiszka
2014-10-26 9:42 ` Gonglei [this message]
2014-10-27 14:18 ` Peter Maydell
2014-10-27 14:39 ` Paolo Bonzini
2014-10-27 15:05 ` Peter Maydell
2014-10-27 16:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544CC1FB.7060702@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=arei.gonglei@hotmail.com \
--cc=jan.kiszka@web.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).