From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XiKVZ-0003my-Be
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 05:53:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XiKVV-0008Ic-0Z
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 05:53:09 -0400
Received: from szxga01-in.huawei.com ([119.145.14.64]:56758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XiKVU-0008IU-Dh
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 05:53:04 -0400
Message-ID: <544CC1FB.7060702@huawei.com>
Date: Sun, 26 Oct 2014 17:42:19 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <544CBFB0.7010701@web.de>
In-Reply-To: <544CBFB0.7010701@web.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT,
 SIGHUP and SIGTERM, synchronously"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Gonglei <arei.gonglei@hotmail.com>

On 2014/10/26 17:32, Jan Kiszka wrote:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks
> debuggability of qemu.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 

Thanks, please add my 'Reported-by' tag and

Reviewed-by: Gonglei <arei.gonglei@huawei.com>

> Feel free to apply this before or after "Make qemu_shutdown_requested
> signal-safe".
> 
>  main-loop.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/main-loop.c b/main-loop.c
> index d2e64f1..53393a4 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -84,9 +84,6 @@ static int qemu_signal_init(void)
>      sigaddset(&set, SIGIO);
>      sigaddset(&set, SIGALRM);
>      sigaddset(&set, SIGBUS);
> -    sigaddset(&set, SIGINT);
> -    sigaddset(&set, SIGHUP);
> -    sigaddset(&set, SIGTERM);
>      pthread_sigmask(SIG_BLOCK, &set, NULL);
>  
>      sigdelset(&set, SIG_IPI);