From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55091)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1XiZ40-0000Fz-9C
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 21:25:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1XiZ3w-0006sk-2T
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 21:25:40 -0400
Received: from [59.151.112.132] (port=13372 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1XiZ3v-0006qV-ID
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 21:25:35 -0400
Message-ID: <544D9F35.1000006@cn.fujitsu.com>
Date: Mon, 27 Oct 2014 09:26:13 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <1414134377-19665-1-git-send-email-wency@cn.fujitsu.com>
	<1414134377-19665-20-git-send-email-wency@cn.fujitsu.com>
	<544A5C6E.6090206@redhat.com>
In-Reply-To: <544A5C6E.6090206@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 19/18] Introduce "xen-load-devices-state"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, xen devel <xen-devel@lists.xen.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, qemu-devl <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Lai Jiangshan <laijs@cn.fujitsu.com>

On 10/24/2014 10:04 PM, Eric Blake wrote:
> On 10/24/2014 01:06 AM, Wen Congyang wrote:
>> Introduce a "xen-load-devices-state" QAPI command that can be used to load
>> the state of all devices, but not the RAM or the block devices of the
>> VM.
>>
>> We only have hmp commands savevm/loadvm, and qmp commands
>> xen-save-devices-state.
>>
>> We use this new command for COLO:
>> 1. suspend both primay vm and secondary vm
>> 2. sync the state
>> 3. resume both primary vm and secondary vm
>>
>> In such case, we need to update all devices's state in any time.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Cc: qemu-devl <qemu-devel@nongnu.org>
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  qapi-schema.json | 18 ++++++++++++++++++
>>  qmp-commands.hx  | 27 +++++++++++++++++++++++++++
>>  savevm.c         | 36 ++++++++++++++++++++++++++++++++++++
>>  3 files changed, 81 insertions(+)
>>
> 
>> +#
>> +# Since: 2.0
>> +##
>> +{ 'command': 'xen-load-devices-state', 'data': {'filename': 'str'} }
> 
> s/2.0/2.2/ - if you even get it in 2.2 (haven't we already passed soft
> freeze, but this is a feature addition?)
> 

I forgot to update it. I will update it in the next version. But this qmp
command is for COLO, so I don't post the next version until xen-4.5 is
released.

Thanks
Wen Congyang