From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57478)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XigVP-0003Ee-Dc
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:22:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XigVK-0005vY-Kw
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:22:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XigVK-0005v1-Dy
	for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:22:22 -0400
Message-ID: <544E0EC5.7020507@redhat.com>
Date: Mon, 27 Oct 2014 10:22:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1414399901-231824-1-git-send-email-kathy.wangting@huawei.com>
In-Reply-To: <1414399901-231824-1-git-send-email-kathy.wangting@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: sense in
	virtio_scsi_command_complete
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ting Wang <kathy.wangting@huawei.com>, qemu-devel@nongnu.org

On 10/27/2014 09:51 AM, Ting Wang wrote:
> If req->resp.cmd.status is not GOOD, the address of sense for
> qemu_iovec_from_buf should be modified from &req->resp to sense.
> 
> Signed-off-by: Ting Wang <kathy.wangting@huawei.com>
> ---
>  hw/scsi/virtio-scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index a1725b8..fe094a5 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -448,7 +448,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
>          sense_len = scsi_req_get_sense(r, sense, sizeof(sense));
>          sense_len = MIN(sense_len, req->resp_iov.size - sizeof(req->resp.cmd));
>          qemu_iovec_from_buf(&req->resp_iov, sizeof(req->resp.cmd),
> -                            &req->resp, sense_len);
> +                            sense, sense_len);
>          req->resp.cmd.sense_len = virtio_tswap32(vdev, sense_len);
>      }
>      virtio_scsi_complete_cmd_req(req);
> 

Embarrassing.  Thanks, applied.

Paolo