From: Max Reitz <mreitz@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
ronniesahlberg@gmail.com, armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length
Date: Mon, 27 Oct 2014 10:23:06 +0100 [thread overview]
Message-ID: <544E0EFA.8040606@redhat.com> (raw)
In-Reply-To: <1414401528-21884-4-git-send-email-pl@kamp.de>
On 2014-10-27 at 10:18, Peter Lieven wrote:
> Copy the max_xfer_len from the BlockLimits VPD or use the
> maximum value fitting in the CDB.
>
> The helper function sector_limits_lun2qemu is introduced to convert
> and cap the limits from the VPD to the maximum power of two fitting
> in an integer; integer is the range for nb_sectors throughout
> the block layer.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
Okay, I think finding the comment in the commit message through git
blame is reasonable.
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-10-27 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 9:18 [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length Peter Lieven
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 1/6] util: introduce MIN_NON_ZERO Peter Lieven
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 2/6] BlockLimits: introduce max_transfer_length Peter Lieven
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length Peter Lieven
2014-10-27 9:23 ` Max Reitz [this message]
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 4/6] block: avoid creating oversized writes in multiwrite_merge Peter Lieven
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits Peter Lieven
2014-10-27 9:24 ` Max Reitz
2014-10-27 9:18 ` [Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests Peter Lieven
2014-10-28 13:31 ` [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E0EFA.8040606@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).