From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XigWL-0004v8-3a for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:23:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XigWG-00069N-55 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:23:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XigWF-00069B-UK for qemu-devel@nongnu.org; Mon, 27 Oct 2014 05:23:20 -0400 Message-ID: <544E0EFA.8040606@redhat.com> Date: Mon, 27 Oct 2014 10:23:06 +0100 From: Max Reitz MIME-Version: 1.0 References: <1414401528-21884-1-git-send-email-pl@kamp.de> <1414401528-21884-4-git-send-email-pl@kamp.de> In-Reply-To: <1414401528-21884-4-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, ronniesahlberg@gmail.com, armbru@redhat.com, stefanha@redhat.com On 2014-10-27 at 10:18, Peter Lieven wrote: > Copy the max_xfer_len from the BlockLimits VPD or use the > maximum value fitting in the CDB. > > The helper function sector_limits_lun2qemu is introduced to convert > and cap the limits from the VPD to the maximum power of two fitting > in an integer; integer is the range for nb_sectors throughout > the block layer. > > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Okay, I think finding the comment in the commit message through git blame is reasonable. Reviewed-by: Max Reitz