From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty
Date: Mon, 27 Oct 2014 09:44:08 -0600 [thread overview]
Message-ID: <544E6848.7080802@redhat.com> (raw)
In-Reply-To: <544DFCF7.5050503@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 10/27/2014 02:06 AM, Max Reitz wrote:
> On 2014-10-24 at 18:31, Eric Blake wrote:
>> On 10/24/2014 07:57 AM, Max Reitz wrote:
>>> Add a test for qcow2's fast bdrv_make_empty implementation on images
>>> without internal snapshots.
>>>
>>> +for event in l1_update empty_image_prepare reftable_update
>>> refblock_alloc; do
>> Is it also worth a test where no I/O error occurs, to be sure we cover
>> the common case output? Maybe by adding '' to this list...
>>
> That should be covered by the test added by the previous patch. I hope.
Ah, that does look like it covers it. Maybe it's worth a comment such
as 'this test covers failures in the middle of an operation; success is
covered by test 097'? Up to you.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-27 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 13:57 [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 01/14] qcow2: Allow "full" discard Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 02/14] qcow2: Implement bdrv_make_empty() Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 03/14] qcow2: Optimize bdrv_make_empty() Max Reitz
2014-10-24 14:33 ` Eric Blake
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 04/14] blockjob: Introduce block_job_complete_sync() Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 05/14] blockjob: Add "ready" field Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 06/14] iotests: Omit length/offset test in 040 and 041 Max Reitz
2014-10-24 15:14 ` Eric Blake
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 07/14] block/mirror: Improve progress report Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP Max Reitz
2014-10-24 16:08 ` Eric Blake
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 09/14] qemu-img: Empty image after commit Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 10/14] qemu-img: Enable progress output for commit Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 11/14] qemu-img: Specify backing file " Max Reitz
2014-10-24 16:23 ` Eric Blake
2014-10-27 9:11 ` Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 12/14] iotests: Add _filter_qemu_img_map Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 13/14] iotests: Add test for backing-chain commits Max Reitz
2014-10-24 13:57 ` [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty Max Reitz
2014-10-24 16:31 ` Eric Blake
2014-10-27 8:06 ` Max Reitz
2014-10-27 15:44 ` Eric Blake [this message]
2014-10-28 10:38 ` [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP Kevin Wolf
2014-10-29 10:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E6848.7080802@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).