From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XimSu-0004B5-39 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 11:44:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XimSo-0006DZ-UA for qemu-devel@nongnu.org; Mon, 27 Oct 2014 11:44:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XimSo-0006DQ-LA for qemu-devel@nongnu.org; Mon, 27 Oct 2014 11:44:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9RFi9s4031328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Oct 2014 11:44:09 -0400 Message-ID: <544E6848.7080802@redhat.com> Date: Mon, 27 Oct 2014 09:44:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414159063-25977-1-git-send-email-mreitz@redhat.com> <1414159063-25977-15-git-send-email-mreitz@redhat.com> <544A7EE8.6070008@redhat.com> <544DFCF7.5050503@redhat.com> In-Reply-To: <544DFCF7.5050503@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JEeNjUNNiRFV6bEjjT2fhmN4UPd4h7qEX" Subject: Re: [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JEeNjUNNiRFV6bEjjT2fhmN4UPd4h7qEX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/27/2014 02:06 AM, Max Reitz wrote: > On 2014-10-24 at 18:31, Eric Blake wrote: >> On 10/24/2014 07:57 AM, Max Reitz wrote: >>> Add a test for qcow2's fast bdrv_make_empty implementation on images >>> without internal snapshots. >>> >>> +for event in l1_update empty_image_prepare reftable_update >>> refblock_alloc; do >> Is it also worth a test where no I/O error occurs, to be sure we cover= >> the common case output? Maybe by adding '' to this list... >> > That should be covered by the test added by the previous patch. I hope.= Ah, that does look like it covers it. Maybe it's worth a comment such as 'this test covers failures in the middle of an operation; success is covered by test 097'? Up to you. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JEeNjUNNiRFV6bEjjT2fhmN4UPd4h7qEX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUTmhIAAoJEKeha0olJ0NqyFoH/RaKKUJG58dEwIcFsx7A/Sc0 8qsA6M09H/zGL17EZBlkbtGgMH7PUXmBRbTEgMe97Rw+8dKNCllQ6BVYIP+TwZ86 1ZWehvUKivZ+tlSnUuC1K1lu7FCSIU7v+9xOJbWq2rzQDVqPkesIMPdfV4SfIkgy g5I4PKBYj0bm6s93GOa/gpZDy41cXlY37AcLPU/0lJlvbALPPcWRZyGk2Qq4xXCa oCNDnIZeUoEzgA29jr03pBC7yEvDts8bm+QstR/inx5b4+i5cCR2frFUE5fsoL7D l8qJ8Vyyyt1VYtUpjltLh2Gqmyxnsv7XW+Fif1ws5G+BdR+q6W42bUtzIfsqTtM= =clkg -----END PGP SIGNATURE----- --JEeNjUNNiRFV6bEjjT2fhmN4UPd4h7qEX--