From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XinoV-0002Cy-P8 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XinoM-000230-IK for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XinoM-00022X-BR for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:10:30 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9RHASto022524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Oct 2014 13:10:29 -0400 Message-ID: <544E7C83.4070301@redhat.com> Date: Mon, 27 Oct 2014 11:10:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414428082-7341-1-git-send-email-marcel.a@redhat.com> <1414428082-7341-3-git-send-email-marcel.a@redhat.com> In-Reply-To: <1414428082-7341-3-git-send-email-marcel.a@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4MgSFExIOoeUUD7FjuerKN1puuo1otf5s" Subject: Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: marcel@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com, armbru@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4MgSFExIOoeUUD7FjuerKN1puuo1otf5s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=3D0 option is an user error, s/an/a/ (user is pronounced with a leading hard "y" sound rather than a soft "u", it may help to remember you can "give a unicorn an umbrella") > do not allow the device to be hot-plugged. >=20 > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/pci.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4MgSFExIOoeUUD7FjuerKN1puuo1otf5s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUTnyDAAoJEKeha0olJ0NqGhsH/RtzROjUI3nnUadJMlIPoOAW oxQOrDP2y8rh/P4nuuF3OXI9KY0qsl66fsT+ablLpZyyU0evBp95Du+W7/I6Zcyr 5wRcnth+V9snBbThj0gKREMOOKxpNpG76boMTRh9i+hpSKwBnflJaAmqENUQvJAW kGxHKW6k0z3SwnWIlTf8hsZI9FaeQcVpdi41kI1se5ssgXpQffRHYEtfFrxSShab RdN3HmsrvUVuBYlc5OGgpdgpTQXF9qYjkjzmX7Dm5IfsW3CMVCtMIh16weteNlNR 5fThsED4xnA+zgO4Rb3pYUYfPpepPBnJeuaB8Z3URRE9+xwXb0lrPYNS3zPoBOc= =n1UN -----END PGP SIGNATURE----- --4MgSFExIOoeUUD7FjuerKN1puuo1otf5s--