From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj59h-0005L6-K9 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj59a-0002dI-Tu for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:41:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj59a-0002dE-M8 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:41:34 -0400 Message-ID: <544F80E6.5030506@redhat.com> Date: Tue, 28 Oct 2014 12:41:26 +0100 From: Max Reitz MIME-Version: 1.0 References: <1414256153-10148-1-git-send-email-pl@kamp.de> <1414256153-10148-3-git-send-email-pl@kamp.de> <20141028111438.GG19211@stefanha-thinkpad.redhat.com> In-Reply-To: <20141028111438.GG19211@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Peter Lieven Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, qemu-devel@nongnu.org, armbru@redhat.com On 2014-10-28 at 12:14, Stefan Hajnoczi wrote: > On Sat, Oct 25, 2014 at 06:55:49PM +0200, Peter Lieven wrote: >> This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. >> The list will absorb all options that belong to the BDS (and not the >> BlockBackend) and will be parsed and handled in bdrv_open_common. >> >> Signed-off-by: Kevin Wolf >> Signed-off-by: Peter Lieven >> Reviewed-by: Max Reitz >> --- >> block.c | 38 +++++++++++++++++++++++++++++++++----- >> 1 file changed, 33 insertions(+), 5 deletions(-) > Is this purely because the QemuOptsList API is more convenient than > qdict? > > I don't see a deeper reason why we must use QemuOptsList here. If I remember correctly, it was because the command line options are only strings in the QDict. To be able to use types other than strings, it has to be converted to QemuOpts. Max