From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes
Date: Wed, 29 Oct 2014 01:27:33 +0100 [thread overview]
Message-ID: <54503475.6050500@redhat.com> (raw)
In-Reply-To: <54502F9B.2070901@redhat.com>
>> Yeah, I was wondering if any commands could have <512 bytes response...
>> I sort of convinced myself that the answer was no for ATA commands, but
>> stupidly forgot about packet (SCSI) commands. Their results are
>> obviously shorter than 512 bytes.
>
> Are you referencing the sglist underflow patch? (#5 instead of #3)
Hmm, yeah.
> There were cases in the code already where we /assumed/ that having any bytes
> implied we had at least a sector's worth.
Even for ATAPI?
If there are valid cases for
> the sglist to have less than a sector's worth (SCSI) then I'll need to
> touch that again as well and update all the assumptions in the IDE code
> to look for numbytes instead of numsectors.
cmd_inquiry can return 36 bytes. That can be both PIO and DMA. SeaBIOS
only uses the DMA variant for AHCI.
Paolo
next prev parent reply other threads:[~2014-10-29 0:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 22:55 [Qemu-devel] [PATCH 0/6] AHCI Device Fixes John Snow
2014-10-01 22:55 ` [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses John Snow
2014-10-27 9:32 ` Markus Armbruster
2014-10-27 15:43 ` John Snow
2014-10-27 15:59 ` Markus Armbruster
2014-10-01 22:55 ` [Qemu-devel] [PATCH 2/6] ahci: Update byte count after DMA completion John Snow
2014-10-01 22:55 ` [Qemu-devel] [PATCH 3/6] ide: repair PIO transfers for cases where nsector > 1 John Snow
2014-10-01 22:55 ` [Qemu-devel] [PATCH 4/6] ahci: unify sglist preparation John Snow
2014-10-01 22:55 ` [Qemu-devel] [PATCH 5/6] ide: Correct handling of malformed/short PRDTs John Snow
2014-10-27 10:06 ` Paolo Bonzini
2014-10-27 18:30 ` John Snow
2014-10-01 22:55 ` [Qemu-devel] [PATCH 6/6] ahci: Fix SDB FIS Construction John Snow
2014-10-16 9:36 ` [Qemu-devel] [PATCH 0/6] AHCI Device Fixes John Snow
2014-10-25 20:03 ` Michael S. Tsirkin
2014-10-27 10:07 ` Paolo Bonzini
2014-10-28 13:51 ` Stefan Hajnoczi
2014-10-28 23:54 ` John Snow
2014-10-29 0:03 ` Paolo Bonzini
2014-10-29 0:06 ` John Snow
2014-10-29 0:27 ` Paolo Bonzini [this message]
2014-10-29 1:28 ` John Snow
2014-10-29 8:58 ` Paolo Bonzini
2014-10-30 10:52 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54503475.6050500@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).