From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XjSqN-00071t-Cz
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 08:59:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XjSqH-0000Z8-4S
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 08:59:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28276)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XjSqG-0000Z4-TL
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 08:59:13 -0400
Message-ID: <5450E380.1090907@redhat.com>
Date: Wed, 29 Oct 2014 13:54:24 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1414584016-25888-1-git-send-email-hare@suse.de>
	<1414584016-25888-11-git-send-email-hare@suse.de>
In-Reply-To: <1414584016-25888-11-git-send-email-hare@suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/13] megasas: Implement
	DCMD_CLUSTER_RESET_LD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>, qemu-devel@nongnu.org
Cc: Andreas Faerber <afaerber@suse.de>, Nic Bellinger <nab@linux-iscsi.org>, Alexander Graf <agraf@suse.de>



On 10/29/2014 01:00 PM, Hannes Reinecke wrote:
> +    trace_megasas_dcmd_reset_ld(cmd->index, target_id);
> +    for (i = 0; i < s->fw_cmds; i++) {
> +        MegasasCmd *tmp_cmd = &s->frames[i];
> +        if (tmp_cmd->req && tmp_cmd->req->dev->lun == target_id) {

Why ->lun?

Paolo

> +            SCSIDevice *d = tmp_cmd->req->dev;
> +            qdev_reset_all(&d->qdev);