From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjcAq-0001fg-7f for qemu-devel@nongnu.org; Wed, 29 Oct 2014 18:57:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjcAl-0006CZ-5X for qemu-devel@nongnu.org; Wed, 29 Oct 2014 18:57:04 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:8621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjcAk-0006Bo-V8 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 18:56:59 -0400 Message-ID: <545170B5.7000509@imgtec.com> Date: Wed, 29 Oct 2014 22:56:53 +0000 From: Leon Alrae MIME-Version: 1.0 References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com> <1414546928-54642-5-git-send-email-yongbok.kim@imgtec.com> In-Reply-To: <1414546928-54642-5-git-send-email-yongbok.kim@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yongbok Kim Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 29/10/14 01:41, Yongbok Kim wrote: > > Signed-off-by: Yongbok Kim > --- > target-mips/op_helper.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index 7cbf4cf..e878442 100644 > --- a/target-mips/op_helper.c > +++ b/target-mips/op_helper.c > @@ -90,10 +90,10 @@ static inline type do_##name(CPUMIPSState *env, target_ulong addr, \ > } \ > } > #endif > +HELPER_LD(lbu, ldub, uint8_t) > +HELPER_LD(lhu, lduw, uint16_t) > HELPER_LD(lw, ldl, int32_t) > -#ifdef TARGET_MIPS64 > HELPER_LD(ld, ldq, int64_t) > -#endif > #undef HELPER_LD > > #if defined(CONFIG_USER_ONLY) > @@ -118,10 +118,9 @@ static inline void do_##name(CPUMIPSState *env, target_ulong addr, \ > } > #endif > HELPER_ST(sb, stb, uint8_t) > +HELPER_ST(sh, stw, uint16_t) > HELPER_ST(sw, stl, uint32_t) > -#ifdef TARGET_MIPS64 > HELPER_ST(sd, stq, uint64_t) > -#endif > #undef HELPER_ST > > target_ulong helper_clo (target_ulong arg1) I agree with James, you could squash it into the patch which uses these functions. Anyway, Reviewed-by: Leon Alrae