From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xjkh0-00027q-QD
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 04:02:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xjkgr-0003KL-U2
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 04:02:50 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:18767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xjkgr-0003K7-O3
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 04:02:41 -0400
Message-ID: <5451F091.40501@imgtec.com>
Date: Thu, 30 Oct 2014 08:02:25 +0000
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com>
	<1414546928-54642-13-git-send-email-yongbok.kim@imgtec.com>
In-Reply-To: <1414546928-54642-13-git-send-email-yongbok.kim@imgtec.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 12/20] target-mips: add MSA BIT format
	instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 29/10/14 01:42, Yongbok Kim wrote:
> +    uint8_t wd = (ctx->opcode >> 6) & 0x1f;
> +
> +    if ((dfm & 0x40) == 0x00) {
> +        m = dfm & 0x3f;
> +        df = DF_DOUBLE;
> +    } else if ((dfm & 0x60) == 0x40) {
> +        m = dfm & 0x1f;
> +        df = DF_WORD;
> +    } else if ((dfm & 0x70) == 0x60) {
> +        m = dfm & 0x0f;
> +        df = DF_HALF;
> +    } else if ((dfm & 0x78) == 0x70) {
> +        m = dfm & 0x7;
> +        df = DF_BYTE;
> +    } else {
> +        generate_exception(ctx, EXCP_RI);
> +        return;
> +    }
> +
> +    TCGv_i32 tdf = tcg_const_i32(df);

Mixed declarations and code. Otherwise,

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>