From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjjw2-000787-9e for qemu-devel@nongnu.org; Thu, 30 Oct 2014 03:14:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjjvv-0005pz-53 for qemu-devel@nongnu.org; Thu, 30 Oct 2014 03:14:18 -0400 Message-ID: <5451F365.5040506@mail.uni-paderborn.de> Date: Thu, 30 Oct 2014 08:14:29 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1414634608-31292-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1414634608-31292-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-tricore: check return value before using it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-trivial@nongnu.org Cc: qemu-devel@nongnu.org, peter.huangpeng@huawei.com Geez, thanks. I wonder how I missed that. Reviewed-by: Bastian Koppelmann On 10/30/2014 02:03 AM, zhanghailiang wrote: > We reference the return value of cpu before checking whether it is NULL, > The checking code is after that which violates code style. > > It makes no difference if the cpu is NULL, qemu process will terminate. > But one will be 'Segmentation fault' and the other will report a error > which is what we want. > > Signed-off-by: zhanghailiang > --- > hw/tricore/tricore_testboard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c > index eeb4922..a059a20 100644 > --- a/hw/tricore/tricore_testboard.c > +++ b/hw/tricore/tricore_testboard.c > @@ -71,11 +71,11 @@ static void tricore_testboard_init(MachineState *machine, int board_id) > machine->cpu_model = "tc1796"; > } > cpu = cpu_tricore_init(machine->cpu_model); > - env = &cpu->env; > if (!cpu) { > error_report("Unable to find CPU definition"); > exit(1); > } > + env = &cpu->env; > memory_region_init_ram(ext_cram, NULL, "powerlink_ext_c.ram", 2*1024*1024, &error_abort); > vmstate_register_ram_global(ext_cram); > memory_region_init_ram(ext_dram, NULL, "powerlink_ext_d.ram", 4*1024*1024, &error_abort);