From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XjnUT-0002mu-Gg
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 07:02:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XjnUK-0003cN-EM
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 07:02:05 -0400
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:39152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XjnUK-0003b7-4Q
	for qemu-devel@nongnu.org; Thu, 30 Oct 2014 07:01:56 -0400
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Thu, 30 Oct 2014 11:01:54 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 43C881B08076
	for <qemu-devel@nongnu.org>; Thu, 30 Oct 2014 11:01:55 +0000 (GMT)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s9UB1pVY5112082
	for <qemu-devel@nongnu.org>; Thu, 30 Oct 2014 11:01:51 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s9U5xN3P029016
	for <qemu-devel@nongnu.org>; Thu, 30 Oct 2014 01:59:23 -0400
Message-ID: <54521A8E.5000207@de.ibm.com>
Date: Thu, 30 Oct 2014 12:01:34 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1414661809-21383-1-git-send-email-borntraeger@de.ibm.com>
	<CAFEAcA-=T=+5MkWtew24T2Ub8EWs5Xjdy+fk3g-RuTfF1nxvEw@mail.gmail.com>
	<545209EA.6040407@de.ibm.com>
	<CAFEAcA_G_9PFpa+VUHiQLJpjPSzzun4-FD520PP7JiO7v_bM3g@mail.gmail.com>
In-Reply-To: <CAFEAcA_G_9PFpa+VUHiQLJpjPSzzun4-FD520PP7JiO7v_bM3g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false
 positives
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

Am 30.10.2014 10:58, schrieb Peter Maydell:
> On 30 October 2014 09:50, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> Yes, I will try to get some of this fixed in valgrind as well. This will
>> take a little longer though because the code changes are bigger than just
>> 1 line of code. Given that valgrind has around 1 release/year, this patch
>> set is certainly a nice band-aid that is useful for todays development.
> 
> I guess these patches also mean we're not going to get valgrind warnings
> if we forget to initialize a necessary field in the struct.

Yes, thats correct. The alternative would be to not use an designated initializer and instead memset reserved and pad field.

> but I suppose we can live with that.
> 
> -- PMM
>