From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkET1-0006Qp-5D for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjoPA-0005YS-SS for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:00:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjoPA-0005YE-At for qemu-devel@nongnu.org; Thu, 30 Oct 2014 08:00:40 -0400 Message-ID: <5452285B.8070704@redhat.com> Date: Thu, 30 Oct 2014 13:00:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414569232-21357-1-git-send-email-hare@suse.de> <1414569232-21357-4-git-send-email-hare@suse.de> <54521520.4000805@redhat.com> <54522054.1010902@suse.de> In-Reply-To: <54522054.1010902@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/17] scsi: Rename scsi_cdb_length() to scsi_xfer_length() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke , qemu-devel@nongnu.org Cc: Alexander Graf , Nic Bellinger , Andreas Faerber On 10/30/2014 12:26 PM, Hannes Reinecke wrote: > > Why would req->cmd.len be wrong though? Are you masking another bug? > > No. I'm _fixing_ a bug. Sure, I just wasn't sure which/how. :) > scsi_disk.c:scsi_new_request() is just calling scsi_req_alloc(), > which does not set cmd.len. > Yet later on scsi_new_request() uses cmd.len to print out the CDB, > which at the time isn't initialized. Ah, right---req->cmd is set after scsi_new_request() returns. Paolo