From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkEKZ-0002GB-1P for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:42:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjroB-0002W4-LM for qemu-devel@nongnu.org; Thu, 30 Oct 2014 11:38:49 -0400 Received: from mail-qg0-x22a.google.com ([2607:f8b0:400d:c04::22a]:43531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjroB-0002Va-Hc for qemu-devel@nongnu.org; Thu, 30 Oct 2014 11:38:43 -0400 Received: by mail-qg0-f42.google.com with SMTP id i50so3270656qgf.29 for ; Thu, 30 Oct 2014 08:38:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <54525B7E.6080402@twiddle.net> Date: Thu, 30 Oct 2014 08:38:38 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1414684746-13771-1-git-send-email-kbastian@mail.uni-paderborn.de> <1414684746-13771-5-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1414684746-13771-5-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/5] target-tricore: Add instructions of BRR opcode format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 10/30/2014 08:59 AM, Bastian Koppelmann wrote: > Add instructions of BRR opcode format. > Add MASK_OP_BRR_DISP15_SEXT. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - OPC2_32_BRR_LOOPU now uses gen_goto_tb. > - else of OPC2_32_BRR_LOOPU now has comment identifying it. Reviewed-by: Richard Henderson r~