From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkE5x-0005Z3-3Y for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjxM0-0000BW-Vm for qemu-devel@nongnu.org; Thu, 30 Oct 2014 17:34:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjxM0-0000BN-Mq for qemu-devel@nongnu.org; Thu, 30 Oct 2014 17:34:00 -0400 Message-ID: <5452AEC5.10104@redhat.com> Date: Thu, 30 Oct 2014 15:33:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414559044-14501-1-git-send-email-famz@redhat.com> <1414559044-14501-3-git-send-email-famz@redhat.com> In-Reply-To: <1414559044-14501-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IuFNUJ745s98AhWUOXIObPsGDeo8aFSBV" Subject: Re: [Qemu-devel] [PATCH 2/4] block: Add bdrv_get_node_name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Benoit Canet , Markus Armbruster , Max Reitz , Stefan Hajnoczi , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IuFNUJ745s98AhWUOXIObPsGDeo8aFSBV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/28/2014 11:04 PM, Fam Zheng wrote: > This returns the node name of a BDS. Remove the TODO comment and expect= > the callers to be explicit. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 6 +++++- > include/block/block.h | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 Can still return NULL because we don't have Jeff's patches for auto-assigning a node name everywhere, right? But that doesn't matter in the context of this patch, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IuFNUJ745s98AhWUOXIObPsGDeo8aFSBV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUUq7FAAoJEKeha0olJ0NqHVcH/R+1/zRHoqrXDoJA1uEPe2gB yLlemiNCWZh6LhgzId7dCMlA3iZqgPbUOWHfT4en21ycYloajnL0sS3J2Vj6/Kc3 Y1pEMQ3z3aCxoUfYKAbMOe+kuJJr+synuLClyF0Jcr8W2FWD8xSTGBXws68Ln195 bK7U0lqzs86Mk7mwRgY5vizRD76dzxT8BJPgLu99p7aKA7Yt7SDDKite116YOnxd r/Wah6ymau2OUJdSNrR//btH8YvTsydLn7cCiq1zNHPY8Bdk7522aF7xuf99hahI GPrVwNIWnNwXNWVEBeh5camX5aOo1rPTPf3bj+nu0yMx9DevroJoTnFMCM7H6s8= =t6dn -----END PGP SIGNATURE----- --IuFNUJ745s98AhWUOXIObPsGDeo8aFSBV--