From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkE5t-0005MJ-3k for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjxOk-0001ny-0N for qemu-devel@nongnu.org; Thu, 30 Oct 2014 17:36:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjxOj-0001nu-Nb for qemu-devel@nongnu.org; Thu, 30 Oct 2014 17:36:49 -0400 Message-ID: <5452AF6E.8020108@redhat.com> Date: Thu, 30 Oct 2014 15:36:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1414559044-14501-1-git-send-email-famz@redhat.com> <1414559044-14501-4-git-send-email-famz@redhat.com> In-Reply-To: <1414559044-14501-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x8x54AT2IOdNoMkpBvGIepb6jmNo7c8n1" Subject: Re: [Qemu-devel] [PATCH 3/4] block: Include "node-name" if present in query-blockstats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Benoit Canet , Markus Armbruster , Max Reitz , Stefan Hajnoczi , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x8x54AT2IOdNoMkpBvGIepb6jmNo7c8n1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/28/2014 11:04 PM, Fam Zheng wrote: > Node name is a better identifier of BDS. >=20 > We will want to query statistics of a BDS node buried in the BDS graph,= > so reporting the node's name if there is one will do the good. s/do the good/do the trick/ > +++ b/qapi/block-core.json > @@ -408,6 +408,8 @@ > # @device: #optional If the stats are for a virtual block device, the = name > # corresponding to the virtual block device. > # > +# @device: #optional The node name of the device. (Since 2.3) Yeah, we missed soft freeze and this is a feature, so your versioning is correct. The node-name would become non-optional once Jeff's patches auto-assign a node name, right? > +# > # @stats: A @BlockDeviceStats for the device. > # > # @parent: #optional This describes the file block device if it has on= e. > @@ -418,7 +420,8 @@ > # Since: 0.14.0 > ## > { 'type': 'BlockStats', > - 'data': {'*device': 'str', 'stats': 'BlockDeviceStats', > + 'data': {'*device': 'str', '*node-name': 'str', > + 'stats': 'BlockDeviceStats', > '*parent': 'BlockStats', Indentation looks odd here. Fix that, and: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x8x54AT2IOdNoMkpBvGIepb6jmNo7c8n1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUUq9uAAoJEKeha0olJ0NqXOoH/2pd55Ql4R+xWyF2CnqCbk8B oM/QqxLf8/n8J1YJnIkWQ55s+zWYfvoqnqcWmqyJOpX0q2qLksTbz7ekJx3aPCXA nFKAt9hDrlWMV/oSh/FytjuqJGDorRwjpEo3HI6rYprsEmciVYNRgkvI1lzYzU3E WptNw+MaeOqhCKHJ7E3acdTThEWSHROHdl3g6/9k/dKGZIf3zlsajM+mIPUTnTUs 4yQRsJI7ngRbE3zOzSrdPb4N0ZvG4J+wWjCW1om5/aLQHg8qrvFaSds+se58RWFB j84kSzpSSTG3TqrTksyxBANK+ae1fSHgaRGAGH/O7bFeQyWolhhPAs574G5MRdw= =SGcB -----END PGP SIGNATURE----- --x8x54AT2IOdNoMkpBvGIepb6jmNo7c8n1--