Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] dump: fix use-after-free for s->fd

[Michael Tokarev <mjt@tls.msk.ru>]

31.10.2014 04:43, Gonglei wrote:
> On 2014/10/30 21:54, Michael Tokarev wrote:
> 
>> So I'm applying this -- which is your patch and your commit message, and
>> I really wonder why this is Reviewed-by and not Signed-off-by, with your
>> authorship?  It really should be...
> 
> Yes, maybe it should be. But I have to say something:
> First, I posted a patch fix the fd leak problem. Markus reviewed it and gave
> his reviewing comments which I think is better, and then I posted
> the version 2 with Markus' suggestion. As your meaning, I should add the
> Signed-off-by tag of Markus? But for me, I don't get Markus' authorization,
> so I can't do this, and maybe he have other comments for version 2.

Um.  I didn't want to offend you in any way.  I was just pointing out that
it was actually Marcus who did the rest of the work, besides discovering the
original problem.  Again, it is both his change and his commit message...

Let's agree to have Signed-off-by from both of you ;)

Thanks,

/mjt