From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] pidfile: stop making pidfile error a special case
Date: Fri, 31 Oct 2014 16:10:22 +0800 [thread overview]
Message-ID: <545343EE.70006@huawei.com> (raw)
In-Reply-To: <54534211.8050102@msgid.tls.msk.ru>
On 2014/10/31 16:02, Michael Tokarev wrote:
> 31.10.2014 10:58, Gonglei wrote:
>> On 2014/10/31 15:41, Michael Tokarev wrote:
> []
>>>>>>> + exit(len == 1 && status == 0 ? 0 : 1);
>>>>>
>>>>> ...it is checked here, note the 'len == 1' part of the condition.
>>>>
>>>> If len != 1, the original code exit with 1, after your changes,
>>>> it will exit with 0. Right?
>>>
>>> with len != 1, the condition 'len == 1 && status == 0 ? 0 : 1'
>>
>> Ok. That's will be great if you can modify it
>> to "(len == 1 && status == 0 ) ? 0 : 1"
>
> Well, ? operator has lowest precedence in C, && and || is higher,
> and == is even higher. That's the basic rules of the language.
> So I don't really see why... ;)
>
> The comment however should clear all confusion, hopefully.
>
Hmm...
BTW, Do you receive mails subscribed form Qemu community?
Does the Qemu maillist system crash?
Since yesterday evening, my colleagues and I do not received mails.
It's too weird!
Thanks!
-Gonglei
next prev parent reply other threads:[~2014-10-31 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 15:07 [Qemu-devel] [PATCH 0/4] cleanup -daemonize and pidfile creation a bit Michael Tokarev
2014-10-30 15:07 ` [Qemu-devel] [PATCH 1/4] os-posix: use global daemon_pipe instead of cryptic fds[1] Michael Tokarev
2014-10-31 4:57 ` Gonglei
2014-10-30 15:07 ` [Qemu-devel] [PATCH 2/4] os-posix: replace goto again with a proper loop Michael Tokarev
2014-10-31 4:58 ` Gonglei
2014-10-30 15:07 ` [Qemu-devel] [PATCH 3/4] pidfile: stop making pidfile error a special case Michael Tokarev
2014-10-31 5:00 ` Gonglei
2014-10-31 7:16 ` Michael Tokarev
2014-10-31 7:33 ` Gonglei
2014-10-31 7:41 ` Michael Tokarev
2014-10-31 7:58 ` Gonglei
2014-10-31 8:02 ` Michael Tokarev
2014-10-31 8:10 ` Gonglei [this message]
2014-10-30 15:07 ` [Qemu-devel] [PATCH 4/4] os-posix: reorder parent notification for -daemonize Michael Tokarev
2014-10-31 5:02 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545343EE.70006@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).