From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDqc-0000p8-6i for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xk7dQ-0005fV-0f for qemu-devel@nongnu.org; Fri, 31 Oct 2014 04:32:45 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:45876 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xk7dP-0005f3-MK for qemu-devel@nongnu.org; Fri, 31 Oct 2014 04:32:39 -0400 Message-ID: <54534924.4060909@kamp.de> Date: Fri, 31 Oct 2014 09:32:36 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1414256153-10148-1-git-send-email-pl@kamp.de> <1414256153-10148-5-git-send-email-pl@kamp.de> <20141028111743.GH19211@stefanha-thinkpad.redhat.com> In-Reply-To: <20141028111743.GH19211@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 4/6] hw/virtio-blk: add a constant for max number of merged requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Am 28.10.2014 um 12:17 schrieb Stefan Hajnoczi: > On Sat, Oct 25, 2014 at 06:55:51PM +0200, Peter Lieven wrote: >> As it was not obvious (at least for me) where the 32 comes from; >> add a constant for it. >> >> Signed-off-by: Peter Lieven >> Reviewed-by: Max Reitz >> --- >> hw/block/virtio-blk.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Stefan Hajnoczi Found out later that this patch is incomplete. The 32 appears in vitio-blk.h for the limit of requests. So it has to be defined and also used there. Peter