From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XkEfW-0006Ta-7W
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 12:03:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XkEfS-0002yW-41
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 12:03:18 -0400
Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:41599)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XkEfR-0002xg-Qq
	for qemu-devel@nongnu.org; Fri, 31 Oct 2014 12:03:14 -0400
Received: by mail-la0-f52.google.com with SMTP id pv20so4715076lab.11
	for <qemu-devel@nongnu.org>; Fri, 31 Oct 2014 09:03:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5453B2B8.8060709@redhat.com>
Date: Fri, 31 Oct 2014 17:03:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410799208-3250-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1410799208-3250-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 0/4] ivshmem security fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Sebastian Krahmer <krahmer@suse.com>, "Michael S. Tsirkin" <mst@redhat.com>, David Marchand <david.marchand@6wind.com>, Bruce Rogers <brogers@suse.com>, Sebastian Krahmer <krahmer@suse.de>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cam Macdonell <cam@cs.ualberta.ca>

On 15/09/2014 18:40, Andreas Färber wrote:
> Hello,
> 
> This series tightens security on incoming data for ivshmem, originally sparked
> by SUSE's security team (Sebastian Krahmer). I've combined them and tackled
> remaining review feedback.
> 
> Regards,
> Andreas
> 
> Changes from Sebastian's #2:
> * Rebased onto Stefan's patches
> * Dropped g_realloc() check (Stefan)
> * Fixed fd leak and appended a patch fixing another one (Stefan)
> * Simplified comment (Stefan)
> 
> Changes from Stefan's series:
> * Modified to handle partial reads (Peter/Gerd)
> * Changed check from > to >= (Peter)
> 
> Cc: Cam Macdonell <cam@cs.ualberta.ca>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sebastian Krahmer <krahmer@suse.de>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: David Marchand <david.marchand@6wind.com>
> 
> Andreas Färber (1):
>   ivshmem: Fix fd leak on error
> 
> Sebastian Krahmer (1):
>   ivshmem: Fix potential OOB r/w access
> 
> Stefan Hajnoczi (2):
>   ivshmem: Check ivshmem_read() size argument
>   ivshmem: validate incoming_posn value from server
> 
>  hw/misc/ivshmem.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 60 insertions(+), 6 deletions(-)
> 

These seem to have falled on the floor, and they're a dependency for
Andrew's error_report cleanup, so I picked them up.

Paolo