From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlD7b-0000O1-Qa for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:36:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlD7X-0005lw-O8 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:36:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlD7X-0005lo-GG for qemu-devel@nongnu.org; Mon, 03 Nov 2014 03:36:15 -0500 Message-ID: <54573E7B.4040705@redhat.com> Date: Mon, 03 Nov 2014 09:36:11 +0100 From: Max Reitz MIME-Version: 1.0 References: <1414731141-13086-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1414731141-13086-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: changed to proper enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 2014-10-31 at 05:52, SeokYeon Hwang wrote: > To fix compiler warning on clang > 3.4, changed to proper enum type. > > Signed-off-by: SeokYeon Hwang > --- > block.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/block.c b/block.c > index 88f6d9b..50845a4 100644 > --- a/block.c > +++ b/block.c > @@ -3540,10 +3540,10 @@ static void send_qmp_error_event(BlockDriverState *bs, > BlockErrorAction action, > bool is_read, int error) > { > - BlockErrorAction ac; > + IoOperationType operation; > > - ac = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE; > - qapi_event_send_block_io_error(bdrv_get_device_name(bs), ac, action, > + operation = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE; > + qapi_event_send_block_io_error(bdrv_get_device_name(bs), operation, action, > bdrv_iostatus_is_enabled(bs), > error == ENOSPC, strerror(error), > &error_abort); Hi, thank you for this patch, but the reason I did not review it is because there were already a couple of these on the mailing list, and Stefan already merged one of them to his block tree; see: http://lists.nongnu.org/archive/cgi-bin/namazu.cgi?query=BlockErrorAction+IoOperationType&submit=Search!&idxname=qemu-devel&max=20&result=normal&sort=score The patch Stefan merged is here: https://github.com/stefanha/qemu/commit/eaedb4cb2706a0ad4698d556aa2a8b091962d545 Max