From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGBY-0005tw-Qq for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlGBS-0000kS-24 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:52:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGBR-0000kL-Q7 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 06:52:30 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA3BqTE1025480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 3 Nov 2014 06:52:29 -0500 Message-ID: <54576C78.3090306@redhat.com> Date: Mon, 03 Nov 2014 12:52:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414773522-7756-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1414773522-7756-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/11] pc: kvm: memory hotplug fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com On 31/10/2014 17:38, Igor Mammedov wrote: > Series > * fixes [1/11] QEMU crash when non aligned DIMM is used in KVM mode. > * adds extra checks/enforcement to avoid non aligned DIMM address/sizes > and prevents guest failures when it tries to deal with such DIMMs > * prevents QEMU from starting with not baked by KVM amount of > memory slots > * fixes hotplug-memory region fragmentation, enabled for 2.2 and newer > * enforces backend alignment on DIMMs address/size for optimal > performance, enabled for 2.2 and newer > > > Igor Mammedov (11): > pc: kvm: check if KVM has free memory slots to avoid abort() > kvm: provide API to query amount of memory slots supported by KVM > pc: check if KVM has enough memory slots for DIMM devices > pc: make pc_dimm_plug() more readble > pc: limit DIMM address and size to page aligned values > memory: expose alignment used for allocating RAM as MemoryRegion API > pc: add pc_init_pci_2_1() and pc_compat_2_1() > pc: align DIMM's address/size by backend's alignment value > pc: pc-dimm: use backend alignment during address auto allocation > pc: explicitly check maxmem limit when adding DIMM > pc: count in 1Gb hugepage alignment when sizing hotplug-memory > container > > exec.c | 9 +++-- > hw/i386/pc.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++-- > hw/i386/pc_piix.c | 16 +++++++- > hw/i386/pc_q35.c | 16 +++++++- > hw/mem/pc-dimm.c | 19 +++++++++- > include/exec/exec-all.h | 2 +- > include/exec/memory.h | 2 + > include/hw/i386/pc.h | 4 ++ > include/hw/mem/pc-dimm.h | 2 +- > include/qemu/osdep.h | 3 +- > include/sysemu/kvm.h | 2 + > kvm-all.c | 32 +++++++++++++++- > kvm-stub.c | 10 +++++ > memory.c | 5 +++ > target-s390x/kvm.c | 2 +- > util/oslib-posix.c | 5 ++- > util/oslib-win32.c | 2 +- > 17 files changed, 212 insertions(+), 17 deletions(-) > I think avoiding aborts is enough. For now, mst, please drop patches 2 and 3. Paolo